Thoughts on Scorched Silver for a johto replay?

if you've done hgss more than once, yes. the point of it is a bigger dex and the quality of life stuff, and a harder gym curve, so it's a replay hack rather than a first time hack. if this would be your first johto run do vanilla soulsilver first, you'll appreciate what the hack changed a lot more.