riolu won't evolve even though I've had it for ages

Riolu doesn't evolve by level. It needs high friendship and it has to be daytime when it levels up. Keep it in your party, walk around with it, give it vitamins or a Soothe Bell if you have one, and avoid letting it faint. Once the friendship is high, level it once during the day and it'll evolve.