Connecting xbox controller to xbox is going nowhere

Each controller only remembers one console, so if it was ever paired to another one it'll keep trying that one. Do the pair button on both again. Worth updating it through the Xbox Accessories app too. An out of date pad can refuse to stay connected.

quickest way is a usb-c cable - plug it in and it's done, no pairing dance. wireless, hold the small pair button on the top edge of the pad next to the charge port until the logo flashes fast, then press the pair button on the console. if the logo flashes and then dies on you it's nearly always the batteries rather than the pairing.